Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

addresses #350 by adding batching operations to apply.generic() and apply.by_query() #351

Merged
merged 1 commit into from
Dec 7, 2022
Merged

addresses #350 by adding batching operations to apply.generic() and apply.by_query() #351

merged 1 commit into from
Dec 7, 2022

Conversation

cmacdonald
Copy link
Contributor

No description provided.

@cmacdonald cmacdonald self-assigned this Dec 7, 2022
seanmacavaney
seanmacavaney approved these changes Dec 7, 2022
View reviewed changes
Copy link
Collaborator

@seanmacavaney seanmacavaney left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@cmacdonald
Copy link
Contributor Author

reviews faster than test cases, amazing!

@seanmacavaney
Copy link
Collaborator

ha, figured it was urgent given ya pinged me on it :D

@cmacdonald cmacdonald merged commit 09ca678 into master Dec 7, 2022
@cmacdonald cmacdonald deleted the issue_350_applybatching branch December 7, 2022 18:36
@cmacdonald cmacdonald linked an issue Dec 7, 2022 that may be closed by this pull request
add batch_size for pt.apply.generic #350
Closed
@cmacdonald cmacdonald added this to the 0.9 milestone Dec 7, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@seanmacavaney seanmacavaney seanmacavaney approved these changes

Assignees

@cmacdonald cmacdonald

Labels
None yet
Projects
None yet
Milestone
0.9
Development

Successfully merging this pull request may close these issues.

add batch_size for pt.apply.generic
2 participants
@cmacdonald @seanmacavaney