fix error when a query field is named "query" #303
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some datasets have a query field called "query". We need to remove it or we'll end up with multiple "query" columns, which will cause problems because many components are written assuming no columns have the same name.
This only affects a few datasets. I went with
irds:clueweb09/catb/trec-web-2009in the test because it only needs to download the topics file (compared to BEIR, which would need to download an archive that contains the corpus, etc.) Plus, the topic file is mirrored, so we'll probably not encounter issues arising from intermittent network failures.fixes #302