fix LTR groupby for xgboost & lightgbm #284
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
|
test failure now addressed |
seanmacavaney
approved these changes
Mar 30, 2022
|
What Sean had identified was indeed a bug affecting xgboost or lightgbm integration. In training or validation sets with differing number of results per query, counts per query would not be correctly ordered, and hence documents could be associated to the wrong query by the learner. This fixes the issue through sorting of the resultset, and introduces a new unit test to check the issue. In most LTR scenarios, there will be 1000 docs per query, but I'll examine differences in a realistic LTR setting. |
seanmacavaney
approved these changes
Mar 30, 2022
cmacdonald
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.