Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

defer loading ir_datasets #280

Merged
merged 1 commit into from
Feb 28, 2022
Merged

defer loading ir_datasets #280

merged 1 commit into from
Feb 28, 2022

Conversation

seanmacavaney
Copy link
Collaborator

Context: calling ir_datasets.load can give a warning message that indicates if a dataset is deprecated. Without this change, the warning would come up every time, regardless of whether the dataset was actually used. With the change, the warning will only appear if the user specifically requests the dataset and does something with it (only the first time).

This change does not degrade the behaviour of on-demand generated datasets (such as those from CLIRMatrix), as the load is not deferred in that cause.

@cmacdonald
Copy link
Contributor

Doesnt this undo #263?

@seanmacavaney
Copy link
Collaborator Author

Nope -- deferred loading only happens for datasets explicitly in the registry -- which are by definition existent. On-demand generated datasets (such as those from CLIRMatrix) are loaded as they are requested, so it'll throw an error if it doesn't exist.

It looks like the failed tests are due to the current lapse of availability of the ANTIQUE collection -- see here: https://github.com/seanmacavaney/ir-datasets.com/runs/5363947696

@cmacdonald
Copy link
Contributor

OK.

I think CIIR.umass.edu is just slow, but its currently up.

@cmacdonald cmacdonald merged commit 1ea9d04 into master Feb 28, 2022
@seanmacavaney seanmacavaney deleted the seanmacavaney-patch-2 branch March 1, 2022 11:11
@seanmacavaney seanmacavaney mentioned this pull request Apr 1, 2022
@cmacdonald cmacdonald added this to the 0.9 milestone Nov 10, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants