Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Filter out non-indexed/metadata fields when indexing #267

Merged
merged 1 commit into from
Jan 13, 2022

Conversation

seanmacavaney
Copy link
Collaborator

fixes #266

Also tried this fix with the example in #266 and it worked.

@cmacdonald
Copy link
Contributor

Whats the overhead of a new level of generator function for all IterDict indexing?

@seanmacavaney
Copy link
Collaborator Author

seanmacavaney commented Jan 13, 2022

There's naturally a bit of overhead in the iteration itself:

With filter: 2.53s+/-0.01
Without filter: 2.43s+/-0.02

(On antique, 5 samples)

But the difference is negligible compared to the duration and variation of the entire indexing process:

With filter: 25.03+/-0.18
Without filter: 25.00+/-0.22

@cmacdonald cmacdonald merged commit c993cb5 into terrier-org:master Jan 13, 2022
@cmacdonald
Copy link
Contributor

Thanks Sean

@seanmacavaney seanmacavaney deleted the bugfix-266 branch January 13, 2022 10:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Not able to index Trec-core-2017
2 participants