Set dtype for qrels columns at read time in io method #254
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Good spot, and thanks for this PR. I updated a corresponding test case. |
|
Good thinking about the test case and thanks for accepting! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The current approach allows pandas to infer the type of each column at read time and then the types for the
qidanddocnocolumns are forced to bestr. This could result in unexpected behavior if one of those fields is number-like with leading zeros.This would make it so a
docnoorqidsuch as0001is read as1by pandas, and then casted to"1".This change makes it so, pandas gets the type explicitly and the field can be read directly as
"0001", thus conserving the leading zeros.(I also removed some trailing space in the source code)