Terrier weighting models expressed in Python #215
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…to from_dataset136
…to from_dataset136
…ing other tests like joblib
|
(unit tests pass once terrier-python-helper is installed.) |
There was a problem hiding this comment.
This is really cool!
Have you tested the performance difference between a pure java wmodel vs one of these? I'd expect there to be some impact, as there's overhead in jnius when switching between python and java. If it's noticeable, it might be worth mentioning this in the documentation.
Besides that, looks good to me.
| #TODO consider the context state? | ||
|
|
||
| @staticmethod | ||
| def from_dataset(dataset : Union[str,Dataset], |
There was a problem hiding this comment.
looks like this belongs in a different PR?
There was a problem hiding this comment.
I started from a from_dataset branch, but I think this bit is already merged.
|
Efficiency timings on Vaswani for the record: |
seanmacavaney
approved these changes
Aug 10, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.