Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

IRDS corpus_iter are not subscriptable #315

Closed
cmacdonald opened this issue Jul 31, 2022 · 1 comment · Fixed by #316
Closed

IRDS corpus_iter are not subscriptable #315

cmacdonald opened this issue Jul 31, 2022 · 1 comment · Fixed by #316
Labels
bug Something isn't working
Milestone
0.9

Comments

@cmacdonald
Copy link
Contributor

Describe the bug
IRDS corpus_iter are not subscriptable

To Reproduce

dataset = pt.get_dataset('irds:msmarco-passage')
corpus = dataset.get_corpus_iter()[2824500:2824700]

Expected behavior
IRDS are itself subscriptable, so this should work

Additional context

The GeneratorLen object in PyTerrier is the problem - see https://github.com/terrier-org/pyterrier/blob/master/pyterrier/datasets.py#L30-L39
@cmacdonald cmacdonald added the bug Something isn't working label Jul 31, 2022
cmacdonald added a commit that referenced this issue Jul 31, 2022
@cmacdonald
addresses #315 IRDS corpus_iter are not subscriptable
9ee1f5e
@cmacdonald cmacdonald linked a pull request Jul 31, 2022 that will close this issue
addresses #315 IRDS corpus_iter are not subscriptable #316
Merged
@cmacdonald
Copy link
Contributor Author

For future reference, the API is now:
def get_corpus_iter(self, verbose=True, start=0, count=None):
for IRDS datasets

cmacdonald added a commit that referenced this issue Aug 1, 2022
@cmacdonald
addresses #315 IRDS corpus_iter are not subscriptable
3ba46c2
@cmacdonald cmacdonald added this to the 0.9 milestone Aug 26, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
0.9
Development

Successfully merging a pull request may close this issue.

addresses #315 IRDS corpus_iter are not subscriptable terrier-org/pyterrier
1 participant
@cmacdonald