Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

pt.Experiment() alters the input measures list to drop "mrt" #301

Closed
cmacdonald opened this issue Apr 27, 2022 · 0 comments
Closed

pt.Experiment() alters the input measures list to drop "mrt" #301

cmacdonald opened this issue Apr 27, 2022 · 0 comments
Assignees
@cmacdonald
Labels
bug Something isn't working
Milestone
0.9

Comments

@cmacdonald
Copy link
Contributor

Describe the bug
eval_metrics takes a list which can include "mrt" measure. The passed list is altered.

To Reproduce

measures = ["mrt"]
pt.Experiment(..., eval_metrics=measures)
assert len(measures) == 1 # assertion fails

Expected behavior
measures should not be altered

Additional context
Bug on this line https://github.com/terrier-org/pyterrier/blob/master/pyterrier/pipelines.py#L427
@cmacdonald cmacdonald added the bug Something isn't working label Apr 27, 2022
@cmacdonald cmacdonald added this to the 0.9 milestone Apr 27, 2022
@cmacdonald cmacdonald self-assigned this Apr 27, 2022
cmacdonald added a commit that referenced this issue Apr 28, 2022
@cmacdonald
addresses #301
886c0da
cmacdonald added a commit that referenced this issue Apr 28, 2022
@cmacdonald
addresses #301 - mrt measure removed from measures
4889abf
cmacdonald added a commit that referenced this issue Apr 28, 2022
@cmacdonald
addresses #301 - mrt measure removed from measures
fd439fc
cmacdonald added a commit that referenced this issue Apr 30, 2022
@cmacdonald
add test for #301
ff41534
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@cmacdonald cmacdonald

Labels
bug Something isn't working
Projects
None yet
Milestone
0.9
Development

No branches or pull requests
1 participant
@cmacdonald