Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SourceTransformer does not pass through additional query-like columns #287

Closed
cmacdonald opened this issue Apr 1, 2022 · 0 comments
Closed
Labels
bug Something isn't working
Milestone

Comments

@cmacdonald
Copy link
Contributor

Describe the bug
SourceTransformer does not pass through query columns

Test Case

    def test_query_cols(self):
        queries = pt.new.queries(["this is a query"], query_embs=[[1,1]])
        self.assertTrue("query_embs" in queries.columns)
        docs = pt.new.ranked_documents([[1, 2]], qid=["1"])
        rtr = pt.transformer.SourceTransformer(docs).transform(queries)
        self.assertTrue("query" in rtr.columns)
        self.assertTrue("score" in rtr.columns)
        self.assertTrue("docno" in rtr.columns)
        self.assertTrue("query_embs" in rtr.columns)
        self.assertEqual(2, len(rtr))
        

Expected behavior
additional query-like columns should be passed through

Additional context

pt.model.query_columns() has a definition that should be used by SourceTransformer

@cmacdonald cmacdonald added the bug Something isn't working label Apr 1, 2022
cmacdonald added a commit that referenced this issue Apr 10, 2022
* pass through extra columns, addresses #287
* address regression and improve tests
@cmacdonald cmacdonald added this to the 0.8 milestone Apr 10, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant