Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Migrate to Python 3.7 minimum #241

Closed
cmacdonald opened this issue Nov 10, 2021 · 2 comments
Closed

Migrate to Python 3.7 minimum #241

cmacdonald opened this issue Nov 10, 2021 · 2 comments
Labels
enhancement New feature or request
Milestone
0.8

Comments

@cmacdonald
Copy link
Contributor

Colab is on 3.7. Could we move to Python 3.7 minimum?

Python 3.7 has better type hints support, particularly for classes with methods that return more instances of the class.

Further releases in 0.7.x would emit a warning if Py 36 is used.

Any blockers on this, e.g. Faiss support?
@cmacdonald cmacdonald added the enhancement New feature or request label Nov 10, 2021
@cmacdonald
Copy link
Contributor Author

I seem to be OK using Faiss on Python 3.7.

@cmacdonald
Copy link
Contributor Author

3.10 not yet supported - see allenai/ir_datasets#140 (comment)

cmacdonald added a commit that referenced this issue Dec 9, 2021
@cmacdonald
Py37 minimum warning, addresses #241
dd71ea7
@cmacdonald cmacdonald added this to the 0.8 milestone Dec 20, 2021
cmacdonald added a commit that referenced this issue Dec 20, 2021
@cmacdonald
Move to Python 3.7 minimum #241
545ee52 
Merge pull request #255 from terrier-org/py37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
0.8
Development

No branches or pull requests
1 participant
@cmacdonald