Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

dataframe coercion #227

Closed
cmacdonald opened this issue Sep 14, 2021 · 0 comments · Fixed by #230
Closed

dataframe coercion #227

cmacdonald opened this issue Sep 14, 2021 · 0 comments · Fixed by #230
Assignees
@seanmacavaney
Labels
bug Something isn't working
Milestone
0.7

Comments

@cmacdonald
Copy link
Contributor

Describe the bug
qids or docnos that are not strings can cause problems in pytrec_eval

Expected behavior
We should coerce datatypes for standard dataframe in pt.Experiment

In model.py, we should have coercion method(s)

  • df.qid.astype(str) (when not an object)
  • df.docno.astype(str) (when not an object)
  • df.score.astype(float) (when is an object, e.g. tensor, and/or not a float/int)
@cmacdonald cmacdonald added the bug Something isn't working label Sep 14, 2021
@cmacdonald cmacdonald added this to the 0.7 milestone Sep 14, 2021
This was referenced Sep 17, 2021
Closed
Merged
cmacdonald pushed a commit that referenced this issue Sep 17, 2021
@seanmacavaney
df coerce (#230) addresses #227
3170ed9
cmacdonald added a commit that referenced this issue Mar 9, 2022
@cmacdonald
addresses #227, max_passage() etc should drop docid
b0c685a
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@seanmacavaney seanmacavaney

Labels
bug Something isn't working
Projects
None yet
Milestone
0.7
Development

Successfully merging a pull request may close this issue.

df coerce terrier-org/pyterrier
df coerce terrier-org/pyterrier
2 participants
@cmacdonald @seanmacavaney