Skip to content

Commit

Permalink
fix test_maven
Browse files Browse the repository at this point in the history
Assumed that version numbers could be parsed as floats
  • Loading branch information
seanmacavaney authored Aug 22, 2024
1 parent 8f59a37 commit 9b7491e
Showing 1 changed file with 2 additions and 2 deletions.
4 changes: 2 additions & 2 deletions tests/test_maven.py
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@

from packaging.version import Version
from pyterrier.java import mavenresolver
import unittest
import shutil
Expand All @@ -24,7 +24,7 @@ def tearDown(self):

def testVersion(self):
ver = mavenresolver.latest_version_num("org.terrier", "terrier-core")
self.assertGreaterEqual(float(ver), 5.3)
self.assertGreaterEqual(Version(ver), Version('5.3'))

def testDownload(self):
ver = mavenresolver.latest_version_num("org.terrier", "terrier-python-helper")
Expand Down

0 comments on commit 9b7491e

Please sign in to comment.