#358: stringify properties and controls, addresses #357

pyterrier/__init__.py

@@ -319,15 +319,15 @@ def set_property(k, v):
         methods or arguments. So this method should be seen as a safety-valve - a way to override the 
         Terrier configuration not explicitly supported by PyTerrier.
     """
-    properties[k] = v
+    properties[str(k)] = str(v)
     ApplicationSetup.bootstrapInitialisation(properties)
 
 def set_properties(kwargs):
     """
         Allows to set many properties in Terrier's global properties configuration
     """
-    for control, value in kwargs.items():
-        properties.put(control, value)
+    for key, value in kwargs.items():
+        properties[str(key)] = str(value)
     ApplicationSetup.bootstrapInitialisation(properties)
 
 def run(cmd, args=[]):

pyterrier/batchretrieve.py

@@ -218,7 +218,7 @@ def __init__(self, index_location, controls=None, properties=None, metadata=["do
         if props is None:
             importProps()
         for key, value in self.properties.items():
-            self.appSetup.setProperty(key, str(value))
+            self.appSetup.setProperty(str(key), str(value))
 
         self.controls = _mergeDicts(BatchRetrieve.default_controls, controls)
         if wmodel is not None:
@@ -459,10 +459,10 @@ def __str__(self):
 
     def setControls(self, controls):
         for key, value in controls.items():
-            self.controls[key] = value
+            self.controls[str(key)] = str(value)
 
     def setControl(self, control, value):
-        self.controls[control] = value
+        self.controls[str(control)] = str(value)
 
 
 

pyterrier/index.py

@@ -438,7 +438,7 @@ def setProperty(self, k, v):
         Usage::
             indexer.setProperty("termpipelines", "")
         """
-        self.properties.put(k, v)
+        self.properties.put(str(k), str(v))
 
     def setProperties(self, **kwargs):
         """
@@ -450,8 +450,8 @@ def setProperties(self, **kwargs):
         Usage:
             >>> setProperties(**{property1:value1, property2:value2})
         """
-        for control, value in kwargs.items():
-            self.properties.put(control, value)
+        for key, value in kwargs.items():
+            self.properties.put(str(key), str(value))
 
     def checkIndexExists(self):
         """

tests/test_init.py

@@ -0,0 +1,9 @@
+import unittest
+import pyterrier as pt, pandas as pd
+from .base import BaseTestCase
+
+class TestInit(BaseTestCase):
+
+    def test_set_property(self):
+        pt.set_property("arbitrary.property", 40)
+        self.assertEqual("40", pt.ApplicationSetup.appProperties.getProperty("arbitrary.property", "none"))