Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

customize theme colors in d2-config #1777

Merged
merged 4 commits into from
Dec 14, 2023
Merged

customize theme colors in d2-config #1777

merged 4 commits into from
Dec 14, 2023

Conversation

alixander
Copy link
Collaborator

Screen Shot 2023-12-13 at 12 17 57 PM

closes #1487

@alixander alixander changed the title customize theme colors in vars-config customize theme colors in d2-config Dec 13, 2023
@alixander alixander force-pushed the customize-themes branch 3 times, most recently from 27da0cb to f43bfda Compare December 13, 2023 20:30
@gavin-ts
Copy link
Contributor

gavin-ts commented Dec 13, 2023 •
edited
Loading

looks good but I'm not sure why this doesn't seem to work with go build . && ./d2 test.d2 I was trying to test the color validation that shows this message when running the e2e test with an invalid color (B4: not a color) e2e_test.go:258: unexpected error: Invalid color format, not a color, but it compiles without error and without the overrides applying

@alixander
Copy link
Collaborator Author

@gavin-ts good call, added validation

@alixander alixander merged commit 37bd766 into terrastruct:master Dec 14, 2023
3 checks passed
@alixander alixander deleted the customize-themes branch December 14, 2023 21:19
@BrewTestBot BrewTestBot mentioned this pull request Dec 17, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gavin-ts gavin-ts gavin-ts approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

customize theme colors with d2-config var
2 participants
@alixander @gavin-ts