Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix cloud innerbox #1736

Merged
merged 6 commits into from
Nov 21, 2023
Merged

Fix cloud innerbox #1736

merged 6 commits into from
Nov 21, 2023

Conversation

gavin-ts
Copy link
Contributor

@gavin-ts gavin-ts commented Nov 17, 2023

Summary

The cloud shape has multiple inner boxes to use depending on the aspect ratio of the content, but getInnerBox was selecting which one with its own aspect ratio instead of the aspect ratio of its content.
This updates the cloud shape so that getInnerBox returns the correct one.

Details

before/after

Screenshot 2023-11-16 at 6 39 21 PM

shaped_grid_position cloud before/after

Screenshot 2023-11-16 at 6 38 41 PM

with old bounding box + incorrect positioning

Screenshot 2023-11-16 at 5 48 10 PM

with new bounding box + correct positioning

Screenshot 2023-11-16 at 6 31 37 PM

contentAspectRatio is now saved for cloud shapes

Screenshot 2023-11-16 at 6 57 23 PM

e2ereport

_Users_gavinnishizawa_github_repos_d2_e2etests_out_e2e_report html

the 3 different innerBoxes for reference

cloud boxes

@gavin-ts gavin-ts marked this pull request as ready for review November 17, 2023 03:00
@gavin-ts gavin-ts merged commit 14db474 into terrastruct:master Nov 21, 2023
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

fix cloud shape innerBox selection
2 participants