Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

grid: fix dynamic layout cuts #1380

Merged
merged 6 commits into from
Jun 8, 2023
Merged

grid: fix dynamic layout cuts #1380

merged 6 commits into from
Jun 8, 2023

Conversation

gavin-ts
Copy link
Contributor

@gavin-ts gavin-ts commented Jun 8, 2023 •
edited
Loading

Summary

Fixes a rare bug in grid layout where a shape could end up on the next row or column when only grid-rows or grid-columns is specified.

Details

  • fixes grid dimensions not working with latex #1374
  • adds grid_with_latex test
  • adds TestGenLayout
  • fixes bug measuring row length including an extra gap at the end
  • fixes bug ending a row with a single object
  • adjusts check for starting a new row to use full gap instead of gap/2
  • Note: bug is based on object dimensions and not related to use of LaTeX

before/after (each should have 2 columns)

Screen Shot 2023-06-08 at 1 06 36 PM

e2ereport

_Users_gavinnishizawa_github_repos_d2_e2etests_out_e2e_report html

@gavin-ts gavin-ts requested a review from alixander June 8, 2023 20:24
@gavin-ts gavin-ts marked this pull request as ready for review June 8, 2023 20:24
@gavin-ts gavin-ts enabled auto-merge June 8, 2023 20:24
@gavin-ts gavin-ts merged commit f568cdd into terrastruct:master Jun 8, 2023
@chenrui333 chenrui333 mentioned this pull request Jun 9, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alixander alixander alixander approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

grid dimensions not working with latex
2 participants
@gavin-ts @alixander