fix: update count condition

terraform-do-modules · Jul 11, 2023 · 17f2149 · 17f2149
1 parent 1b7da15
commit 17f2149
Show file tree

Hide file tree

Showing 3 changed files with 5 additions and 11 deletions.
diff --git a/_examples/database_firewall/example.tf b/_examples/database_firewall/example.tf
@@ -9,11 +9,10 @@ locals {
 ## database Firewall module call
 ##------------------------------------------------
 module "firewall" {
-  source                    = "./../../"
-  name                      = local.name
-  environment               = local.environment
-  database_firewall_enabled = true
-  database_cluster_id       = "" ## add database cluster id
+  source              = "./../../"
+  name                = local.name
+  environment         = local.environment
+  database_cluster_id = "" ## add database cluster id
   rules = [
     {
       type  = "ip_addr"

diff --git a/main.tf b/main.tf
@@ -64,7 +64,7 @@ resource "digitalocean_firewall" "default" {
 #Description : Provides a DigitalOcean database firewall resource allowing you to restrict connections to your database to trusted sources.
 ##------------------------------------------------------------------------------------------------------------------------------------------
 resource "digitalocean_database_firewall" "default" {
-  count = var.enabled == true && var.database_firewall_enabled && var.database_cluster_id != null ? 1 : 0
+  count = var.enabled == true && var.database_cluster_id != null ? 1 : 0
 
   cluster_id = var.database_cluster_id
 

diff --git a/variables.tf b/variables.tf
@@ -31,11 +31,6 @@ variable "enabled" {
   description = "Flag to control the firewall creation."
 }
 
-variable "database_firewall_enabled" {
-  type        = bool
-  default     = false
-  description = "Flag to control the firewall creation."
-}
 
 variable "allowed_ip" {
   type        = list(any)