Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: Adjust cross-region-replica-postgres example code #554

Merged
merged 1 commit into from
Jun 14, 2024

Conversation

es1o
Copy link
Contributor

@es1o es1o commented Jun 12, 2024

Description

Fixed cross-region-replica-postgress example code by disabling create parameter group for database.

Motivation and Context

create_db_parameter_group is set to true by default. For postgresql replica it can't be created because parameter group is inherited from source db. This variable must be explicite set to false

How Has This Been Tested?

  • I have updated at least one of the examples/* to demonstrate and validate my change(s)
  • I have tested and validated these changes using one or more of the provided examples/* projects
  • I have executed pre-commit run -a on my pull request

@es1o es1o changed the title Fix cross-region-replica-postgres example code fix: cross-region-replica-postgres example code Jun 12, 2024
@es1o es1o changed the title fix: cross-region-replica-postgres example code fix: Adjust cross-region-replica-postgres example code Jun 12, 2024
@bryantbiggs bryantbiggs changed the title fix: Adjust cross-region-replica-postgres example code docs: Adjust cross-region-replica-postgres example code Jun 14, 2024
@bryantbiggs bryantbiggs merged commit d39c573 into terraform-aws-modules:master Jun 14, 2024
24 of 26 checks passed
Copy link

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jul 15, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants