Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Align the default value of manage_master_user_password in the instance sub-module with the root module #531

Conversation

lorenzophys
Copy link
Contributor

Description

Fixed the default value of manage_master_user_password in the db_instance submodule to avoid confusion. See #530

@lorenzophys lorenzophys changed the title chore: fix the default value of manage_master_user_password chore: Fix the default value of manage_master_user_password Jan 10, 2024
Copy link
Member

@bryantbiggs bryantbiggs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thank you!

For reference - #530 (comment)

@bryantbiggs bryantbiggs changed the title chore: Fix the default value of manage_master_user_password fix: Align the default value of manage_master_user_password in the instance sub-module with the root module Jan 10, 2024
@bryantbiggs bryantbiggs merged commit 8b90616 into terraform-aws-modules:master Jan 10, 2024
25 of 26 checks passed
antonbabenko pushed a commit that referenced this pull request Jan 10, 2024
### [6.3.1](v6.3.0...v6.3.1) (2024-01-10)

### Bug Fixes

* Align the default value of `manage_master_user_password` in the instance sub-module with the root module ([#531](#531)) ([8b90616](8b90616))
@antonbabenko
Copy link
Member

This PR is included in version 6.3.1 🎉

Copy link

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Feb 10, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants