fix: Change allocated_storage type from string to number
#507
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fix: updated the allocated storage type from string to number
techieforfun
changed the title
bryantbiggs
changed the title
allocated_storage type from string to number
bryantbiggs
merged commit 5939ddf
into
terraform-aws-modules:master
22 of 23 checks passed
antonbabenko
pushed a commit
that referenced
this pull request
Aug 5, 2023
### [6.1.1](v6.1.0...v6.1.1) (2023-08-05) ### Bug Fixes * Change `allocated_storage` type from string to number ([#507](#507)) ([5939ddf](5939ddf))
|
This PR is included in version 6.1.1 🎉 |
|
I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The
allocated_storagetype of the DB Instance is aninteger, as indicated in the AWS documentation. This change has been reflected in this module, transitioning it from astringto anumber.Motivation and Context
To adhere to the AWS API data type convention.
Breaking Changes
No
How Has This Been Tested?
examples/*to demonstrate and validate my change(s)examples/*projectsThe examples already shows data in
numberformat, however I test it via different types including both string and number values.pre-commit run -aon my pull request