Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Update examples #497

Merged

Conversation

daroga0002
Copy link
Contributor

Description

update examples because they were failing because error:

│ Error: Unsupported argument
│ 
│   on .terraform/modules/vpc/main.tf line 1246, in resource "aws_default_vpc" "this":
│ 1246:   enable_classiclink   = null # https://github.com/hashicorp/terraform/issues/31730
│ 

Motivation and Context

Because examples are not working on latest provider

Breaking Changes

no

How Has This Been Tested?

  • I have updated at least one of the examples/* to demonstrate and validate my change(s)
  • [] I have tested and validated these changes using one or more of the provided examples/* projects
  • I have executed pre-commit run -a on my pull request

@daroga0002 daroga0002 changed the title update examples chore: update examples Jun 1, 2023
@daroga0002 daroga0002 changed the title chore: update examples Chore: update examples Jun 1, 2023
@daroga0002 daroga0002 changed the title Chore: update examples chore: update examples Jun 1, 2023
@daroga0002 daroga0002 changed the title chore: update examples chore: Update examples Jun 1, 2023
@daroga0002 daroga0002 mentioned this pull request Jun 1, 2023
3 tasks
@bryantbiggs bryantbiggs merged commit 51ededc into terraform-aws-modules:master Jun 9, 2023
20 of 24 checks passed
@daroga0002 daroga0002 deleted the update-examples branch June 9, 2023 11:44
@antonbabenko
Copy link
Member

This PR is included in version 6.0.0 🎉

@github-actions
Copy link

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jul 26, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants