Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add output for SQL Server listener_endpoint #486

Merged
merged 6 commits into from
May 3, 2023
Merged

feat: Add output for SQL Server listener_endpoint #486

merged 6 commits into from
May 3, 2023

Conversation

gpontbriand
Copy link
Contributor

@gpontbriand gpontbriand commented Mar 28, 2023

Description

Adds an output variable mapping for the listener_endpoint output of the aws_db_instance resource

Please see this link for official docs:
https://registry.terraform.io/providers/hashicorp/aws/latest/docs/resources/db_instance

Motivation and Context

This output variable is needed when working with RDS for SQL Server and Always On Availability Group (AG)

Breaking Changes

None.

How Has This Been Tested?

Tested with terraform apply since it's just an extra output variable.

"Specifies the listener connection endpoint for SQL Server Always On"
@gpontbriand gpontbriand changed the title Add output for listener_endpoint fix: Add output for listener_endpoint Mar 28, 2023
@gpontbriand gpontbriand changed the title fix: Add output for listener_endpoint feat: Add output for listener_endpoint Apr 5, 2023
@gpontbriand gpontbriand changed the title feat: Add output for listener_endpoint feat: Add output for SQL Server listener endpoint Apr 5, 2023
@bryantbiggs bryantbiggs changed the title feat: Add output for SQL Server listener endpoint feat: Add output for SQL Server listener_endpoint May 2, 2023
Copy link
Member

@bryantbiggs bryantbiggs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thank you!

@bryantbiggs bryantbiggs merged commit 564fae2 into terraform-aws-modules:master May 3, 2023
20 checks passed
antonbabenko pushed a commit that referenced this pull request May 3, 2023
## [5.9.0](v5.8.0...v5.9.0) (2023-05-03)

### Features

* Add output for SQL Server `listener_endpoint` ([#486](#486)) ([564fae2](564fae2))
@antonbabenko
Copy link
Member

This PR is included in version 5.9.0 🎉

@github-actions
Copy link

github-actions bot commented Jun 2, 2023

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jun 2, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants