Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Allow setting master_username when using manage_master_user_password #369

Merged

Conversation

bryantbiggs
Copy link
Member

Description

  • Allow setting master_username when using manage_master_user_password

Motivation and Context

Breaking Changes

  • No

How Has This Been Tested?

  • I have updated at least one of the examples/* to demonstrate and validate my change(s)
  • I have tested and validated these changes using one or more of the provided examples/* projects
  • I have executed pre-commit run -a on my pull request

@bryantbiggs bryantbiggs changed the title fix: fix: Allow setting master_username when using manage_master_user_password Apr 10, 2023
@antonbabenko antonbabenko merged commit f48f824 into terraform-aws-modules:master Apr 11, 2023
antonbabenko pushed a commit that referenced this pull request Apr 11, 2023
### [8.0.2](v8.0.1...v8.0.2) (2023-04-11)

### Bug Fixes

* Allow setting `master_username` when using `manage_master_user_password` ([#369](#369)) ([f48f824](f48f824))
@antonbabenko
Copy link
Member

This PR is included in version 8.0.2 🎉

@bryantbiggs bryantbiggs deleted the fix/master-username branch April 11, 2023 11:01
@github-actions
Copy link

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 12, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Cannot create cluster due to missing username since 8.0.0
2 participants