Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: Add lambda_function_arn format for lambda_function_name #288

Merged
merged 1 commit into from
Apr 10, 2023

Conversation

nylrejco
Copy link
Contributor

@nylrejco nylrejco commented Apr 7, 2023

Description

Add comment explaining 6th index after split function in lambda_function_name value.

Motivation and Context

Lambda function ARN format is not specified in the comments so it is quite confusing why 6th index is taken as the lambda_function_name value

Breaking Changes

This does not have breaking changes and is backward compatible. Only comments are added.

How Has This Been Tested?

  • I have updated at least one of the examples/* to demonstrate and validate my change(s)
  • I have tested and validated these changes using one or more of the provided examples/* projects
  • I have executed pre-commit run -a on my pull request

@antonbabenko antonbabenko merged commit 72e0ce4 into terraform-aws-modules:master Apr 10, 2023
@github-actions
Copy link

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 11, 2023
@antonbabenko
Copy link
Member

This PR is included in version 8.6.1 🎉

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants