Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Default action forward action type #269

Conversation

michaelact
Copy link
Contributor

@michaelact michaelact commented Dec 29, 2022

Description

feat: default-action forward action type

Motivation and Context

AWS Code Deploy Blue/Green Deployment automatically register 2 target group for 1 application. The first one is blue target group, and the other is green target group.

Breaking Changes

No.

How Has This Been Tested?

  • I have updated at least one of the examples/* to demonstrate and validate my change(s)
  • I have tested and validated these changes using one or more of the provided examples/* projects
  • I have executed pre-commit run -a on my pull request
  http_tcp_listeners = [
    {
      port     = 80
      protocol = "HTTP"
      action_type = "forward"
      forward = {
        target_groups = [
          {
            target_group_index = 0
            weight             = 100
          },
          {
            target_group_index = 1
            weight             = 0
          }
        ]
      }
    }
  ]

@michaelact michaelact changed the title feat: default-action forward action type feat: default action forward action type Dec 29, 2022
@michaelact michaelact changed the title feat: default action forward action type feat: Default action forward action type Dec 29, 2022
@antonbabenko antonbabenko merged commit 4a14075 into terraform-aws-modules:master Mar 3, 2023
antonbabenko pushed a commit that referenced this pull request Mar 3, 2023
## [8.4.0](v8.3.1...v8.4.0) (2023-03-03)

### Features

* Default action forward action type ([#269](#269)) ([4a14075](4a14075))
@antonbabenko
Copy link
Member

This PR is included in version 8.4.0 🎉

@michaelact
Copy link
Contributor Author

Thanks @antonbabenko

@github-actions
Copy link

github-actions bot commented Apr 3, 2023

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Apr 3, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants