Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat!: Add ip_address_type to target group resource, bumped AWS provider version #255

Merged
merged 2 commits into from
Sep 16, 2022
Merged

feat!: Add ip_address_type to target group resource, bumped AWS provider version #255

merged 2 commits into from
Sep 16, 2022

Conversation

krewenki
Copy link
Contributor

@krewenki krewenki commented Sep 15, 2022 •
edited
Loading

Description

Adds the ip_address_type resource to the aws_lb_target_group resource so you can specify ipv6 targets.

Motivation and Context

I have a need to create an ipv6 only target group, and the module didn't currently have that ability while AWS did.

Breaking Changes

How Has This Been Tested?

  • I have updated at least one of the examples/* to demonstrate and validate my change(s)
  • I have tested and validated these changes using one or more of the provided examples/* projects
  • I have executed pre-commit run -a on my pull request

@krewenki krewenki changed the title Add ip_address_type to target group resource feat: Add ip_address_type to target group resource Sep 15, 2022
@antonbabenko antonbabenko changed the title feat: Add ip_address_type to target group resource feat!: Add ip_address_type to target group resource, bumped AWS provider version Sep 16, 2022
antonbabenko
antonbabenko requested changes Sep 16, 2022
View reviewed changes
Copy link
Member

@antonbabenko antonbabenko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This change demands AWS provider version 4.27.0, so please update minimum version requirements in versions.tf everywhere. This PR will make its way to a major release.

@krewenki
Copy link
Contributor Author

@antonbabenko The minimum version has been updated to 4.27.0 .

@antonbabenko antonbabenko merged commit 5d08044 into terraform-aws-modules:master Sep 16, 2022
antonbabenko pushed a commit that referenced this pull request Sep 16, 2022
@semantic-release-bot
chore(release): version 8.0.0 [skip ci]
a141aac 
## [8.0.0](v7.0.0...v8.0.0) (2022-09-16)

### ⚠ BREAKING CHANGES

* Add ip_address_type to target group resource, bumped AWS provider version (#255)

### Features

* Add ip_address_type to target group resource, bumped AWS provider version ([#255](#255)) ([5d08044](5d08044))
@antonbabenko
Copy link
Member

This PR is included in version 8.0.0 🎉

@github-actions
Copy link

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Nov 15, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@antonbabenko antonbabenko antonbabenko approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@krewenki @antonbabenko