feat: Added missing cookie_name TG stickiness parameter support
#245
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
antonbabenko
changed the title
SlavaSubotskiy
changed the title
antonbabenko
changed the title
cookie_name TG stickiness parameter support
antonbabenko
changed the title
cookie_name TG stickiness parameter supportcookie_name TG stickiness parameter support
antonbabenko
pushed a commit
that referenced
this pull request
Apr 21, 2022
## [6.10.0](v6.9.0...v6.10.0) (2022-04-21) ### Features * Added missing `cookie_name` TG stickiness parameter support ([#245](#245)) ([a01b7ca](a01b7ca))
|
This PR is included in version 6.10.0 🎉 |
pyToshka
added a commit
to opensource-terraform-modules/terraform-aws-alb
that referenced
this pull request
Apr 25, 2022
* Added missing `cookie_name` TG stickiness parameter support ([terraform-aws-modules#245](terraform-aws-modules#245)) ([a01b7ca](terraform-aws-modules@a01b7ca)) deleted political slogans from repository
|
I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Adding optional
cookie_nameparameter support for the target group stickiness. https://registry.terraform.io/providers/hashicorp/aws/latest/docs/resources/lb_target_group#cookie_nameMotivation and Context
We have got an issue while trying to provision ALB with TG stickiness type
app_cookiedue to a lack ofcookie_nameparameter support.Fixes #242
Breaking Changes
We are not aware of breaking changes. Changes should be backward compatible(one optional parameter support added)
How Has This Been Tested?
lb_cookieandapp_cookie