-
-
Notifications
You must be signed in to change notification settings - Fork 672
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Add support for enable_waf_fail_open and desync_mitigation_mode #235
feat: Add support for enable_waf_fail_open and desync_mitigation_mode #235
Conversation
rerun tests |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please verify the minimum version requirement for these attributes in versions.tf
and update the docs by running pre-commit run -a
.
These attributes are introduced in https://github.com/hashicorp/terraform-provider-aws/releases/tag/v3.67.0 |
Then update min version here. |
@antonbabenko Done |
Awesome 🚢 |
## [6.7.0](v6.6.1...v6.7.0) (2022-02-04) ### Features * Add support for enable_waf_fail_open and desync_mitigation_mode ([#235](#235)) ([a4a79df](a4a79df))
This PR is included in version 6.7.0 🎉 |
I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further. |
Description
Resource aws_lb support enable_waf_fail_open and desync_mitigation_mode, support for which is missing in this module.
I have added support for these options in current aws_lb resource implementation.
Also added the variables for these 2 options.
Motivation and Context
In some cases, it is needed to set enable_waf_fail_open to true. As for supporting critical services, lb should continue to forward requests to targets even if the communication to aws waf fails.
Breaking Changes
Does this break backwards compatibility with the current major version?
No
If so, please provide an explanation why it is necessary.
NA
How Has This Been Tested?
I have tested and validated these changes using one or more of the provided
examples/*
projectsPlease describe in detail how you tested your changes.