Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Remove not required depends_on in aws_lb_target_group #215

Merged
merged 1 commit into from
Aug 14, 2021
Merged

Conversation

Dylan-Feith
Copy link
Contributor

@Dylan-Feith Dylan-Feith commented Jul 13, 2021

It has been introduced in this PR but I do not see any reason for it. A target group can be created without a lb.
#37

In the following PR, some depends_on have been removed but not this one:
#49

Description

Motivation and Context

Breaking Changes

How Has This Been Tested?

  • I have tested and validated these changes using one or more of the provided examples/* projects

It has been introduced in this PR but I do not see any reason for it. A target group can be created without a lb.
#37

In the following PR, some depends_on have been removed but not this one:
#49
@Dylan-Feith
Copy link
Contributor Author

Hi,
PR has been updated to take into account last merge.
Is anything blocking on this PR ?

Thank you.
Dylan

@antonbabenko
Copy link
Member

Hi @Dylan-Feith !

Thank you for this small improvement. I can't see why this was introduced and I think we can safely remove it, so I merge your PR.

@antonbabenko antonbabenko changed the title fix: remove not required depends_on fix: Remove not required depends_on in aws_lb_target_group Aug 14, 2021
@antonbabenko antonbabenko merged commit f51ae89 into terraform-aws-modules:master Aug 14, 2021
@antonbabenko
Copy link
Member

v6.5.0 has been just released.

@github-actions
Copy link

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Nov 15, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants