Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Possible typo in the source code #19

Closed
tunnckoCore opened this issue Feb 28, 2018 · 3 comments
Closed

Possible typo in the source code #19

tunnckoCore opened this issue Feb 28, 2018 · 3 comments

Comments

@tunnckoCore
Copy link

tunnckoCore commented Feb 28, 2018

Heya. As ususal, i always review the whole code of libraries or whatever.

So found that the this.rl here

const rl = readline.createInterface(this.in);
readline.emitKeypressEvents(this.in, this.rl);

probably is meant to be the rl const, because the this.rl is not defined in any other place in the code base, even in that file.

@terkelg
Copy link
Owner

terkelg commented Feb 28, 2018

Interesting - I'll have a look at this tonight

@tunnckoCore
Copy link
Author

Yea, it's a bit sad that ESLint can't (?) handle such things. If there is such rule would be great.

@terkelg terkelg added this to the v0.1.3 milestone Mar 1, 2018
tunnckoCore pushed a commit to tunnckoCore/prompts that referenced this issue Mar 2, 2018
fixes terkelg#35, closes terkelg#19

Signed-off-by: Charlike Mike Reagent <olsten.larck@gmail.com>
@terkelg
Copy link
Owner

terkelg commented Mar 3, 2018

Thanks. I've removed readline in the 'keypress' branch.

@terkelg terkelg closed this as completed Mar 3, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants