Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tasks/295 #329

Merged
merged 4 commits into from
Jul 21, 2017
Merged

Tasks/295 #329

merged 4 commits into from
Jul 21, 2017

Conversation

datphan
Copy link
Contributor

@datphan datphan commented Jun 20, 2017

connects #295

@hoatle
Copy link
Member

hoatle commented Jul 11, 2017

@datphan build failed, need to get it passed.

cc @phuonglm: make sure to send review feedback asap (within 3 days since the day PR was sent)

@CLAassistant
Copy link

CLAassistant commented Jul 13, 2017

CLA assistant check
All committers have signed the CLA.

"docker_registry": {
// set true to force re-login with all the defined entries, default: false (login once)
"force": false,
"entries": [{
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not sure about these default entries. @phuonglm @datphan please consider this, why default here?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@datphan default should be set on override.json instead of vagrant_config.json.

@phuonglm phuonglm merged commit b10207c into teracyhq:develop Jul 21, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants