Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

should use _id: "kernel-core" instead of _id: "0" for the core extension config #545

Closed
hoatle opened this issue Nov 5, 2018 · 0 comments
Closed

should use _id: "kernel-core" instead of _id: "0" for the core extension config #545

hoatle opened this issue Nov 5, 2018 · 0 comments
Assignees
@hoatle
Labels
comp:config config prio:major reso:fixed tag:unplanned type:improvement
Milestone
v0.6.0-a5-dev

Comments

@hoatle
Copy link
Member

hoatle commented Nov 5, 2018

we should use the key instead of index
we should use a prefix to indicate where is the original config is.

So when looking at this _id: "kernel-core" we know that it's from the kernel config.
@hoatle hoatle added this to the v0.6.0-a5-dev milestone Nov 5, 2018
@hoatle hoatle self-assigned this Nov 5, 2018
hoatle added a commit to hoatle/teracy-dev that referenced this issue Nov 5, 2018
@hoatle
@ teracyhq#545 | should use _id: kernel-core instead of _id: 0 for th…
499a24e 
…e core extension config
hoatle added a commit to hoatle/teracy-dev that referenced this issue Nov 5, 2018
@hoatle
@ teracyhq#545 | should use _id: kernel-core instead of _id: 0 for th…
5e088ec 
…e core extension config
@hoatle hoatle mentioned this issue Nov 5, 2018
Merged
@ghost ghost added stag:in-progress and removed sprt:current labels Nov 5, 2018
hoatle added a commit that referenced this issue Nov 5, 2018
@hoatle
Merge pull request #546 from hoatle/improvements/#545-use-kernel-core-id
b7b7ba7 
@ #545 | should use _id: kernel-core instead of _id: 0 for the core extension config
@hoatle hoatle closed this as completed Nov 5, 2018
@ghost ghost removed the stag:under-verification label Nov 5, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@hoatle hoatle

Labels
comp:config config prio:major reso:fixed tag:unplanned type:improvement
Projects
None yet
Milestone
v0.6.0-a5-dev
Development

No branches or pull requests
1 participant
@hoatle