Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

should always use Util.true? for converting boolean values #506

Closed
hoatle opened this issue Oct 16, 2018 · 0 comments
Closed

should always use Util.true? for converting boolean values #506

hoatle opened this issue Oct 16, 2018 · 0 comments

Comments

@hoatle
Copy link
Member

hoatle commented Oct 16, 2018

so that we can use string for boolean values instead of just true or false

Expected:

  • enabled: "true" # or true, "t", "yes", "y", "1" should be converted as true

Actual: only enabled: true is supported.

This is a minor improvement, I thought the following config below would work with the changes from this issue, however, it does not work as the variables processor does not kicks in (hooks) on the teracy-dev-kernel extension config (Maybe we'll think about this later to make this possible).

variables:
  my_extension_enabled: ${MY_EXTENSION_ENABLED:-false}

teracy-dev:
    - _id: "entry-my-extension"
      path:
        extension: project/teracy-dev-my-extension
      location:
        git: git@github.com:org/project.git
        branch: develop
      require_version: ">= 0.1.0-SNAPSHOT"
      enabled: "%{my_extension_enabled}"
@hoatle hoatle added this to the v0.6.0-a5-dev milestone Oct 16, 2018
@hoatle hoatle self-assigned this Oct 16, 2018
@hoatle hoatle changed the title should always use Util.boolean for boolean values should always use Util.true? or Util.boolean for converting boolean values Oct 16, 2018
@hoatle hoatle changed the title should always use Util.true? or Util.boolean for converting boolean values should always use Util.true? for converting boolean values Oct 16, 2018
hoatle added a commit to hoatle/teracy-dev that referenced this issue Oct 16, 2018
@hoatle hoatle assigned hieptranquoc and unassigned hoatle Oct 16, 2018
hoatle added a commit that referenced this issue Oct 17, 2018
@ #506 | should always use Util.true? for converting boolean values
@hoatle hoatle assigned hoatle and unassigned hieptranquoc Oct 17, 2018
@hoatle hoatle closed this as completed Oct 18, 2018
@ghost ghost removed the stag:under-verification label Oct 18, 2018
hoatle added a commit that referenced this issue Oct 24, 2018
@hoatle hoatle added the comp:util util label Oct 26, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants