Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

wrong order in extensions config merge #499

Closed
phuonglm opened this issue Oct 11, 2018 · 1 comment
Closed

wrong order in extensions config merge #499

phuonglm opened this issue Oct 11, 2018 · 1 comment
Assignees
@phuonglm
Labels
reso:fixed tag:unplanned type:bug
Milestone
v0.6.0-a5-dev

Comments

@phuonglm
Copy link
Contributor

phuonglm commented Oct 11, 2018 •
edited
Loading

at this we merge the extensions settings in reverse (LIFO) order while my expected is FIFO.
@phuonglm phuonglm self-assigned this Oct 11, 2018
@hoatle hoatle added this to the v0.6.0-a5-dev milestone Oct 11, 2018
@hoatle
Copy link
Member

hoatle commented Oct 11, 2018

confirmed:

  • expected override paring order: ext-0 < ext-1 < ext-2 < .. < ext-n
  • actual overriding paring order: ext-n > ... > ext-2 > ext-1 > ext-0

phuonglm added a commit to phuonglm/dev that referenced this issue Oct 11, 2018
@phuonglm
wrong order in extensions config merge teracyhq#499
e6f8458
phuonglm added a commit to phuonglm/dev that referenced this issue Oct 11, 2018
@phuonglm
wrong order in extensions config merge teracyhq#499
a566f0a
@phuonglm phuonglm mentioned this issue Oct 11, 2018
Merged
@ghost ghost added stag:in-progress and removed sprt:current labels Oct 11, 2018
hoatle added a commit that referenced this issue Oct 11, 2018
@hoatle
Merge pull request #500 from phuonglm/bug/499-wrong-order-in-extensio…
550fbc1 
…n-config-merge

wrong order in extensions config merge #499
@hoatle hoatle closed this as completed Oct 11, 2018
@ghost ghost removed the stag:under-verification label Oct 11, 2018
phuonglm added a commit to phuonglm/dev that referenced this issue Oct 11, 2018
@phuonglm
wrong order in extensions config merge teracyhq#499
088a8d5
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@phuonglm phuonglm

Labels
reso:fixed tag:unplanned type:bug
Projects
None yet
Milestone
v0.6.0-a5-dev
Development

No branches or pull requests
2 participants
@hoatle @phuonglm