Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

should implement project specific config support feature #321

Closed
hoatle opened this issue Jun 1, 2017 · 8 comments
Closed

should implement project specific config support feature #321

hoatle opened this issue Jun 1, 2017 · 8 comments

Comments

@hoatle
Copy link
Member

hoatle commented Jun 1, 2017

spec from #315

@hoatle hoatle added this to the v0.5.0-c1 milestone Jun 1, 2017
phuonglm added a commit to phuonglm/dev that referenced this issue Jun 15, 2017
phuonglm added a commit to phuonglm/dev that referenced this issue Jul 12, 2017
phuonglm added a commit to phuonglm/dev that referenced this issue Jul 12, 2017
phuonglm added a commit to phuonglm/dev that referenced this issue Jul 14, 2017
phuonglm added a commit to phuonglm/dev that referenced this issue Jul 14, 2017
phuonglm added a commit to phuonglm/dev that referenced this issue Jul 15, 2017
phuonglm added a commit to phuonglm/dev that referenced this issue Jul 17, 2017
hoatle added a commit that referenced this issue Jul 17, 2017
#321 #314  #302 should implement project specific config support feature
@hoatle hoatle assigned hoatle and unassigned phuonglm Jul 17, 2017
@hoatle
Copy link
Member Author

hoatle commented Jul 17, 2017

let me check and improve minor things.

@hoatle
Copy link
Member Author

hoatle commented Jul 17, 2017

@phuonglm bug detected:

macbook-pro:acme-dev hoatle$ vagrant rsync-back
==> default: Rsyncing folder: /home/vagrant/workspace/ => /Users/hoatle/acme-dev/workspace
==> default:   - Exclude: [".vagrant/", ".git", ".idea/", ".#*", "node_modules/", "dist/"]
macbook-pro:acme-dev hoatle$ cd workspace/nextjs-hello-world/
macbook-pro:nextjs-hello-world hoatle$ vagrant rsync-back
Error read file workspace/angular-hello-world/dev-setup/vagrant_config_default.json. Please check if that file exist. Exiting.

when $ vagrant sync-back not from acme-dev but with deeper folder level.

@hoatle
Copy link
Member Author

hoatle commented Jul 17, 2017

@phuonglm I've updated the following branches that use the develop branch of teracy-dev for test the real use case of this feature:

And I think that we should allow missing project config (just warning instead of fatal and exit), for example, from: https://github.com/acme101/dev-setup/blob/develop/vagrant_config_default.json#L5-L6

By that, users don't have to touch or override any configs, it should just work. What do you think?

@hoatle
Copy link
Member Author

hoatle commented Jul 17, 2017

there is one use case in the future that teracy-dev will be splinted into a separated project (teracy-dev-setup that should have the same project layout with other projects and it should be configured as follows:

{
  "vagrant": {
    "config_paths": [ // add paths of json config files to be loaded
      // the path must be relative to the Vagrantfile
      "workspace/teracy-dev-setup/vagrant_config_default.json",
      "workspace/angular-hello-world/dev-setup/vagrant_config_default.json",
      "workspace/nextjs-hello-world/dev-setup/vagrant_config_default.json"
    ]
  }
}

that's it. It's the proof of the future compatibility 💃

@hoatle
Copy link
Member Author

hoatle commented Jul 17, 2017

no more problems detected so far, so @phuonglm please check my comments above and fix, improve things.

@hoatle hoatle assigned phuonglm and unassigned hoatle Jul 17, 2017
phuonglm added a commit to phuonglm/dev that referenced this issue Jul 18, 2017
phuonglm added a commit to phuonglm/dev that referenced this issue Jul 21, 2017
hoatle added a commit that referenced this issue Jul 21, 2017
should implement project specific config support feature #321; fix bug
@hoatle hoatle assigned hoatle and unassigned phuonglm Jul 21, 2017
@hoatle
Copy link
Member Author

hoatle commented Jul 21, 2017

works as expected, closed now.

@hoatle hoatle assigned phuonglm and unassigned hoatle Jul 21, 2017
@hoatle hoatle closed this as completed Jul 21, 2017
@ghost ghost removed the stag:under-verification label Jul 21, 2017
@hoatle hoatle reopened this Jul 21, 2017
@hoatle
Copy link
Member Author

hoatle commented Jul 21, 2017

reopened as there is bug: "override.json" instead of "overide.json"

hoatle added a commit to hoatle/teracy-dev that referenced this issue Jul 21, 2017
hoatle added a commit to hoatle/teracy-dev that referenced this issue Jul 21, 2017
@hoatle hoatle self-assigned this Jul 21, 2017
phuonglm added a commit that referenced this issue Jul 22, 2017
…nfig-support

@ #321 | should implement project specific config support feature: override instead of overide
@hoatle
Copy link
Member Author

hoatle commented Jul 22, 2017

everything should work now, closed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants