-
Notifications
You must be signed in to change notification settings - Fork 29
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Branch Deletion #128
Merged
Merged
Branch Deletion #128
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rlizzo
added
enhancement
New feature or request
WIP
Don't merge; Work in Progress
Awaiting Review
Author has determined PR changes area nearly complete and ready for formal review.
labels
Oct 3, 2019
hhsecond
approved these changes
Oct 4, 2019
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
…tests alongside them in new test module. Altered output of create_branch so that remove and create return same information / structure
Codecov Report
@@ Coverage Diff @@
## master #128 +/- ##
==========================================
+ Coverage 92.1% 92.37% +0.28%
==========================================
Files 60 61 +1
Lines 10087 10333 +246
Branches 999 1007 +8
==========================================
+ Hits 9290 9545 +255
+ Misses 582 572 -10
- Partials 215 216 +1
|
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Awaiting Review
Author has determined PR changes area nearly complete and ready for formal review.
enhancement
New feature or request
WIP
Don't merge; Work in Progress
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation and Context
Why is this change required? What problem does it solve?:
Allow for the ability to remove the pointers to local branches.
If it fixes an open issue, please link to the issue here:
Description
Describe your changes in detail:
See
Repository.remove_branch()
docstrings for overview of utility & considerations taken.The
create_branch()
method was updated to return same results asremove_branch()
(now yielding both the subject branchs` name as well as its referent commit digest). Appropriate modifications were made to the test suite to adapt to (and test) this behavior, and the "branch modification" methods were given their own test module for future clarity as we expand on their abilities.I am currently working on adding analagous methods to the
CLI
, and will push those before this is merged.Types of changes
What types of changes does your code introduce? Put an
x
in all the boxes that apply:Is this PR ready for review, or a work in progress?
How Has This Been Tested?
Put an
x
in the boxes that apply:Checklist:
@hhsecond, let me know what you think.