Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Branch Deletion #128

Merged
merged 4 commits into from
Oct 8, 2019
Merged

Branch Deletion #128

merged 4 commits into from
Oct 8, 2019

Conversation

rlizzo
Copy link
Member

@rlizzo rlizzo commented Oct 3, 2019

Motivation and Context

Why is this change required? What problem does it solve?:

Allow for the ability to remove the pointers to local branches.

If it fixes an open issue, please link to the issue here:

Description

Describe your changes in detail:

See Repository.remove_branch() docstrings for overview of utility & considerations taken.

The create_branch() method was updated to return same results as remove_branch() (now yielding both the subject branchs` name as well as its referent commit digest). Appropriate modifications were made to the test suite to adapt to (and test) this behavior, and the "branch modification" methods were given their own test module for future clarity as we expand on their abilities.

I am currently working on adding analagous methods to the CLI, and will push those before this is merged.

Types of changes

What types of changes does your code introduce? Put an x in all the boxes that apply:

  • Documentation update
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Is this PR ready for review, or a work in progress?

  • Ready for review
  • Work in progress

How Has This Been Tested?

Put an x in the boxes that apply:

  • Current tests cover modifications made
  • New tests have been added to the test suite
  • Modifications were made to existing tests to support these changes
  • Tests may be needed, but they are not included when the PR was proposed
  • I don't know. Help!

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have signed (or will sign when prompted) the tensorwork CLA.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@hhsecond, let me know what you think.

@rlizzo rlizzo added enhancement New feature or request WIP Don't merge; Work in Progress Awaiting Review Author has determined PR changes area nearly complete and ready for formal review. labels Oct 3, 2019
@rlizzo rlizzo requested a review from hhsecond October 3, 2019 06:19
@rlizzo rlizzo self-assigned this Oct 3, 2019
Copy link
Member

@hhsecond hhsecond left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

src/hangar/repository.py Show resolved Hide resolved
@codecov
Copy link

codecov bot commented Oct 8, 2019

Codecov Report

Merging #128 into master will increase coverage by 0.28%.
The diff coverage is 98.21%.

@@            Coverage Diff             @@
##           master     #128      +/-   ##
==========================================
+ Coverage    92.1%   92.37%   +0.28%     
==========================================
  Files          60       61       +1     
  Lines       10087    10333     +246     
  Branches      999     1007       +8     
==========================================
+ Hits         9290     9545     +255     
+ Misses        582      572      -10     
- Partials      215      216       +1
Impacted Files Coverage Δ
src/hangar/records/parsing.py 98.51% <ø> (ø) ⬆️
src/hangar/records/summarize.py 90.41% <ø> (ø) ⬆️
src/hangar/records/queries.py 91.88% <ø> (ø) ⬆️
src/hangar/records/commiting.py 89.92% <ø> (ø) ⬆️
tests/test_cli.py 100% <100%> (ø) ⬆️
tests/test_remotes.py 98.42% <100%> (ø) ⬆️
src/hangar/records/heads.py 93.07% <100%> (+6.27%) ⬆️
tests/test_visualizations.py 100% <100%> (ø) ⬆️
src/hangar/repository.py 96.75% <100%> (+0.11%) ⬆️
src/hangar/utils.py 84.35% <100%> (+1.36%) ⬆️
... and 5 more

@rlizzo rlizzo merged commit 46b7271 into tensorwerk:master Oct 8, 2019
@rlizzo rlizzo mentioned this pull request Oct 8, 2019
@rlizzo rlizzo deleted the branch-delete branch October 15, 2019 19:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Awaiting Review Author has determined PR changes area nearly complete and ready for formal review. enhancement New feature or request WIP Don't merge; Work in Progress
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Branch removal
2 participants