-
Notifications
You must be signed in to change notification settings - Fork 29
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Import export in CLI #103
Import export in CLI #103
Conversation
Hey @hhsecond I took the code you started on and did a massive overhaul of it. Basically took heavy inspiration from scikit-image's plugin infrastructure and utility. The interface needs to be cleaned up a bit still, and we need tests, but both importing and exporting works! Let me know what you think! |
@rlizzo Wow! that's indeed massive. Are we pushing this in 0.2? I was thinking of a basic stable interface which we could push into 0.2 |
Why don't we push it to 0.3? We can make that a quick release. If we're going to put it in 0.2 I'd rather not include a plugin the system (which we haven't had time to thoroughly review and test.) I suppose we could just hard code pillow is a dependency and only allow the file types that it could support. That would serve as a decent proof-of-concept? What are your thoughts? Should we put a limited version in 0.2? Or just push it all to 0.3? (It'll be a short turn around time for that release) |
@rlizzo do you wanna go back to my last commit and push that for 0.2 |
Codecov Report
@@ Coverage Diff @@
## master #103 +/- ##
==========================================
- Coverage 92.54% 92.16% -0.38%
==========================================
Files 51 59 +8
Lines 9448 9858 +410
Branches 930 990 +60
==========================================
+ Hits 8743 9085 +342
- Misses 511 561 +50
- Partials 194 212 +18
|
Hey @hhsecond can you give this a review? The tests are passing now (even though a few more are needed) and the quality is close to where I'm OK with it for the time being. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Overall looks good. I would say we need a PluginManager class eventually instead of several functions and few global containers floating around. What do you think?
Ok. Going to merge this now. |
Motivation and Context
Why is this change required? What problem does it solve?:
Introducing import-export utility over the command line
If it fixes an open issue, please link to the issue here:
This PR won't solve issue #72 completely but starting with image import and export. Also, the release is going to be experimental and the APIs are subjective to change
Description
Describe your changes in detail:
click
click
Types of changes
What types of changes does your code introduce? Put an
x
in all the boxes that apply:Is this PR ready for review, or a work in progress?
How Has This Been Tested?
Put an
x
in the boxes that apply:Checklist: