Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix vocab_size in PositionalEmbedding in Transformer notebook #1266

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Fix vocab_size in PositionalEmbedding in Transformer notebook #1266

wants to merge 2 commits into from

Conversation

8bitmp3
Copy link
Contributor

@8bitmp3 8bitmp3 commented Apr 9, 2024

@MarkDaoust @markmcd

Also addresses #1264

@review-notebook-app Review Notebook App
Copy link

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.

Powered by ReviewNB

@JuanVargas
Copy link

I corrected the code as suggested by Mark Doust and that solved the problem. Thank you!
The code is:

embed_pt = PositionalEmbedding(vocab_size=tokenizers.pt.get_vocab_size().numpy(), d_model=512)
embed_en = PositionalEmbedding(vocab_size=tokenizers.en.get_vocab_size().numpy(), d_model=512)

That said, why is that correction not added to the notebook at the TF site??

copybara-service bot pushed a commit that referenced this pull request May 2, 2024
@lukesandberg @tf-text-github-robot
No public description
0481b76 
FUTURE_COPYBARA_INTEGRATE_REVIEW=#1266 from 8bitmp3:fix-transformer fca8889
PiperOrigin-RevId: 630101186
@copybara-service copybara-service bot mentioned this pull request May 2, 2024
Closed
copybara-service bot pushed a commit that referenced this pull request May 2, 2024
@lukesandberg @tf-text-github-robot
No public description
06383f7 
FUTURE_COPYBARA_INTEGRATE_REVIEW=#1266 from 8bitmp3:fix-transformer fca8889
PiperOrigin-RevId: 630101186
copybara-service bot pushed a commit that referenced this pull request May 16, 2024
@cantonios @tf-text-github-robot
Update tensorflow patch to allow tf-text nightlies to build.
35af7e5 
FUTURE_COPYBARA_INTEGRATE_REVIEW=#1266 from 8bitmp3:fix-transformer fca8889
PiperOrigin-RevId: 634504731
@copybara-service copybara-service bot mentioned this pull request May 16, 2024
Open
copybara-service bot pushed a commit that referenced this pull request May 16, 2024
@cantonios @tf-text-github-robot
Update tensorflow patch to allow tf-text nightlies to build.
17b4f9c 
FUTURE_COPYBARA_INTEGRATE_REVIEW=#1266 from 8bitmp3:fix-transformer fca8889
PiperOrigin-RevId: 634504731
copybara-service bot pushed a commit that referenced this pull request May 16, 2024
@cantonios @tf-text-github-robot
Update tensorflow patch to allow tf-text nightlies to build.
625ec75 
The patch was out-dated.  Applied the changes manually from the latest nightly and re-exported the patch.

FUTURE_COPYBARA_INTEGRATE_REVIEW=#1266 from 8bitmp3:fix-transformer fca8889
PiperOrigin-RevId: 634504731
copybara-service bot pushed a commit that referenced this pull request May 17, 2024
@cantonios @tf-text-github-robot
Update tensorflow patch to allow tf-text nightlies to build.
fc98a90 
The patch was out-dated.  Applied the changes manually from the latest nightly and re-exported the patch.

FUTURE_COPYBARA_INTEGRATE_REVIEW=#1266 from 8bitmp3:fix-transformer fca8889
PiperOrigin-RevId: 634504731
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MarkDaoust MarkDaoust MarkDaoust approved these changes

Assignees

@MarkDaoust MarkDaoust

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@8bitmp3 @JuanVargas @MarkDaoust