BUILD: strip for release build #6765
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bileschi
approved these changes
Feb 27, 2024
|
Just for posterity:
|
AnuarTB
pushed a commit
to AnuarTB/tensorboard
that referenced
this pull request
May 3, 2024
## Motivation for features / changes Potential improvement to the build: reduce the binary size by ~5Mb ## Technical description of changes Run `strip` on release build so that [whatever strip does to the binary] is not shipped in the production build. ## Screenshots of UI changes (or N/A) ## Detailed steps to verify changes work correctly (as executed by you) Run `cargo build --release`, with and without the change, to observe the binary size (as tested on M1 Mac) reducing from 14Mb to 9.5Mb ## Alternate designs / implementations considered (or N/A)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation for features / changes
Potential improvement to the build: reduce the binary size by ~5Mb
Technical description of changes
Run
stripon release build so that [whatever strip does to the binary] is not shipped in the production build.Screenshots of UI changes (or N/A)
Detailed steps to verify changes work correctly (as executed by you)
Run
cargo build --release, with and without the change, to observe the binary size (as tested on M1 Mac) reducing from 14Mb to 9.5MbAlternate designs / implementations considered (or N/A)