Adjust demo scripts to be Keras 3 compatible #6761
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bmd3k
changed the title
bmd3k
changed the title
bmd3k
commented
Feb 16, 2024
| model.add(tf.keras.layers.Dropout(hparams[HP_DROPOUT], seed=rng.random())) | ||
| model.add( | ||
| tf.keras.layers.Dropout( | ||
| hparams[HP_DROPOUT], seed=rng.randrange(1 << 32) |
There was a problem hiding this comment.
Addresses this error:
File "/usr/local/google/home/bdubois/virtualenv/20240215-tensorboard-git-without-keras/lib/python3.11/site-packages/keras/src/layers/regularization/dropout.py", line 53, in __init__
self.seed_generator = backend.random.SeedGenerator(seed)
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
File "/usr/local/google/home/bdubois/virtualenv/20240215-tensorboard-git-without-keras/lib/python3.11/site-packages/keras/src/random/seed_generator.py", line 61, in __init__
raise ValueError(
ValueError: Argument `seed` must be an integer. Received: seed=0.3616904771377427
| @@ -125,11 +125,9 @@ def g(i): | |||
| for step in range(3): | |||
| # Suppress the profiler deprecation warnings from tf.summary.trace_*. | |||
| with _silence_deprecation_warnings(): | |||
| tf.summary.trace_on(profiler=True) | |||
| tf.summary.trace_on(profiler=True, profiler_outdir=logdir) | |||
There was a problem hiding this comment.
Addresses this error:
WARNING:tensorflow:No `profiler_outdir` passed to trace_on(). Profiler won't be enabled.
0
WARNING:tensorflow:Ignoring `profiler_outdir` passed to trace_export(). Please pass it to trace_on() instead.
<snip>
File "/usr/local/google/home/bdubois/virtualenv/20240215-tensorboard-git-without-keras/lib/python3.11/site-packages/tensorflow/python/profiler/profiler_v2.py", line 144, in stop
raise errors.UnavailableError(
tensorflow.python.framework.errors_impl.UnavailableError: Cannot export profiling results. No profiler is running.
| @@ -90,7 +90,7 @@ def keras(): | |||
| model = tf.keras.models.Sequential(layers) | |||
| model.compile( | |||
| loss=tf.keras.losses.mean_squared_error, | |||
| optimizer=tf.keras.optimizers.SGD(lr=0.2), | |||
| optimizer=tf.keras.optimizers.SGD(learning_rate=0.2), | |||
There was a problem hiding this comment.
Addresses this error:
File "/usr/local/google/home/bdubois/virtualenv/20240215-tensorboard-git-without-keras/lib/python3.11/site-packages/keras/src/optimizers/base_optimizer.py", line 38, in __init__
raise ValueError(f"Argument(s) not recognized: {kwargs}")
ValueError: Argument(s) not recognized: {'lr': 0.2}
rileyajones
added a commit
that referenced
this pull request
Feb 20, 2024
## Motivation for features / changes This test behaves differently internally and externally. The changes made in #6761 succeed in getting the test to pass externally, but it will then fail when imported Googlers see (cl/608667862).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adjusts *_demo.py files to work with Keras 3.
The hparams_demo is fully backward compatible with Keras 2 and forward compatible with Keras 3.
Unfortunately the graphs_demo is not backward compatible with Keras 2. Users attempting to run it with Keras 2 will get the following error:
Amazingly, though, the graph that the demo generates with Keras 3 can be successfully loaded in the Graph dashboard. This makes me optimistic to get the Graph plugin fully Keras 3 compatible after addressing the user-reported error in #6686.
Old Keras 2 Graph:
New Keras 3 Graph: