Migrate hparams plugin to Keras 3 and remove Keras 2 from requirements.txt #6759
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
requirements.txt.
bmd3k
force-pushed
the
hparams-keras3
branch
from
963682e
to
eee218f
Compare
yatbear
approved these changes
Feb 15, 2024
| @@ -46,12 +38,12 @@ def _initialize_model(self, writer): | |||
| "optimizer": "adam", | |||
| HP_DENSE_NEURONS: 8, | |||
| } | |||
| self.model = keras.models.Sequential( | |||
| self.model = tf.keras.models.Sequential( | |||
There was a problem hiding this comment.
Just curious but I haven't tested this myself - does this need to be changed to tf.keras.Sequential : https://keras.io/api/models/sequential/
There was a problem hiding this comment.
Looking at the source tf.keras.model.Sequential and tf.keras.Sequential appear to point to the same thing.
bmd3k
added a commit
to bmd3k/tensorboard
that referenced
this pull request
Feb 16, 2024
…s.txt (tensorflow#6759) We must still install keras 2 as part of CI in order to successfully run graph plugin tests.
bmd3k
added a commit
that referenced
this pull request
Feb 16, 2024
…s.txt (#6759) We must still install keras 2 as part of CI in order to successfully run graph plugin tests.
bmd3k
added a commit
that referenced
this pull request
Mar 4, 2024
#6759 modified _keras_test.py to work with Keras 3 but it did not import correctly into the internal repository. It was therefore reverted in #6767. This changes the test to work both in the oss and internal repos. Googlers, see cl/612511563 for sample import results.
AnuarTB
pushed a commit
to AnuarTB/tensorboard
that referenced
this pull request
May 3, 2024
tensorflow#6759 modified _keras_test.py to work with Keras 3 but it did not import correctly into the internal repository. It was therefore reverted in tensorflow#6767. This changes the test to work both in the oss and internal repos. Googlers, see cl/612511563 for sample import results.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We must still install keras 2 as part of CI in order to successfully run graph plugin tests.