Makes runs table use hparam store for hparam columns #6736
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hoonji
commented
Jan 26, 2024
rileyajones
approved these changes
Jan 26, 2024
WORKSPACE
Outdated
There was a problem hiding this comment.
I don't understand why this change was needed. Can you please remove this file from this PR
There was a problem hiding this comment.
Sorry buildifier keeps annoyingly swapping these lines. I'll add this change properly in a separate PR.
Comment on lines
334
to
336
| let columns = [...runsTableHeaders, ...hparamColumns]; | ||
| // Override hparam options to match runs table requirements. | ||
| columns = columns.map((column) => { |
There was a problem hiding this comment.
nitpick: It seems strange to initialize the column array, then immediately remap it.
Suggested change
| let columns = [...runsTableHeaders, ...hparamColumns]; | |
| // Override hparam options to match runs table requirements. | |
| columns = columns.map((column) => { | |
| // Override hparam options to match runs table requirements. | |
| const columns = [ | |
| ...runsTableHeaders, | |
| ...hparamColumns, | |
| ].map((column) => { |
There was a problem hiding this comment.
I was also debating whether to combine these lines. I'll prefer conciseness going forward!
Merged
hoonji
added a commit
that referenced
this pull request
Feb 1, 2024
## Motivation for features / changes Recently merged hparam column PRs (#6732, #6733, #6736) will cause build and lint errors during 1p sync. ## Technical description of changes - import map from rxjs/operators instead of rxjs - `DataTableUtils` -> `dataTableUtils` - use proper string signature on CardStateMap in tests
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation for features / changes
To display shared hparam columns across runs and scalar tables, both should read this data from the same hparam store. This PR first applies this change to the runs table.
Technical description of changes
Updates runs table to use columns from the hparam store, and to dispatch hparam actions
misc:
Screenshots of UI changes (or N/A)
UI works the same
Detailed steps to verify changes work correctly (as executed by you)
Manually verified that adding/removing/filter columns is unchanged