-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixing 6088 : Download CSV data #6719
Conversation
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). View this failed invocation of the CLA check for more information. For the most up to date status, view the checks section at the bottom of the pull request. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the change! After you resolve the comment, please make sure to acquire the CLA following https://github.com/tensorflow/tensorboard/pull/6719/checks?check_run_id=20415071608.
Please fix the lint error: https://github.com/tensorflow/tensorboard/actions/runs/7553563538/job/20577640944?pr=6719 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice work!
Thank you ! My first merge in a Google product 😀 |
Motivation for features / changes
Fixes #6088: Download CSV data
Technical description of changes
Setting good parameters to constructor and adding a default value for an optional parameter
Detailed steps to verify changes work correctly (as executed by you)
Download with no error
Googlers, see b/307370637. @yatbear tested internally at cl/598969320.