tbdev turndown: remove now-unused code in tensorboard/uploader #6705
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nfelt
force-pushed
the
tbdev-removal
branch
2 times, most recently
from
3f5ead9
to
297d90e
Compare
nfelt
changed the title
bmd3k
approved these changes
Jan 8, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #6603
This removes a sizable chunk of the code in the
tensorboard/uploadersubdirectory, now that we've disabled the TensorBoard.dev uploader in #6707. It also removes several Pip package deps that were only needed for the removed code.The remaining code (
logdir_loader.py,upload_tracker.py,util.py, their tests, and the protos) is preserved because it is still depended on either by internal code or by Cloud AI Platform.Note that for
util.py, I've removed everything exceptRateLimitersince that was the only symbol where I could find outside dependencies. To simplify the test code I also foldedFakeTimefromtest_util.pyintoutil_test.py.Tested with an internal sync to confirm tests will still pass (once a few other changes land).