Adds hparam filterbar to runs table #6692
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hoonji
commented
Dec 4, 2023
hoonji
commented
Dec 4, 2023
tensorboard/webapp/runs/views/runs_table/hparam_filterbar_component.ts
Outdated
Show resolved
Hide resolved
|
@JamesHollyer The cl requires some minor changes (need to add icon once I get tf_mirror permissions), but the other parts are ready for review. This is my first major PR on this code base - please be as critical as necessary! |
JamesHollyer
reviewed
Dec 5, 2023
tensorboard/webapp/runs/views/runs_table/hparam_filterbar_component.ts
Outdated
Show resolved
Hide resolved
tensorboard/webapp/runs/views/runs_table/hparam_filterbar_component.ts
Outdated
Show resolved
Hide resolved
tensorboard/webapp/runs/views/runs_table/hparam_filterbar_component.ts
Outdated
Show resolved
Hide resolved
rileyajones
added a commit
that referenced
this pull request
Dec 5, 2023
## Motivation for features / changes I followed my own instructions documented in #6692 I did encounter an issue with the tf mirror cli but I managed to work around it.
|
All changes applied (including the icon)! PTAL. |
JamesHollyer
approved these changes
Dec 6, 2023
|
Right, I was actually looking for something like that. Thanks! |
nfelt
pushed a commit
that referenced
this pull request
Dec 7, 2023
## Motivation for features / changes Copybara sync will complain after #6692 : - Filterbar doesn't use lowerCamelCase in property names (it used a "_" prefix) - runs table BUILD target doesn't include chip dependencies (surprisingly this doesn't affect tests or app execution) This PR addresses both issues
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation for features / changes
To view applied hparam filters in the runs table.
Technical description of changes
If a user filters the runs table based on a hparam column, the filter will be shown as a chip above the table. Clicking the chip will allow the user to modify the filter via a dialog. Clicking the close button on the chip will remove the filter.
Screenshots of UI changes (or N/A)