Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added compatibility for dark theme #6691

Merged
merged 1 commit into from
Dec 12, 2023

Conversation

tummala-manasa
Copy link
Contributor

Motivation for features / changes

Issue #6276

Technical description of changes

The plus button and help icon were not visible in dark theme. Changed the color to the same color as name text.

Screenshots of UI changes (or N/A)

Changed design for black
Screenshot 2023-12-03 at 6 44 53 PM

Working for all colors.
Screenshot 2023-12-03 at 6 44 38 PM

Light theme:
Screenshot 2023-12-03 at 6 44 57 PM

Help icon
Screenshot 2023-12-03 at 6 43 32 PM

Detailed steps to verify changes work correctly (as executed by you)

Go to the graphs tab and select dark theme.

Alternate designs / implementations considered (or N/A)

N/A

Copy link

google-cla bot commented Dec 4, 2023

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

Copy link
Contributor

@groszewn groszewn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! This looks great, you'll need to sign the CLA before I can merge.

@tummala-manasa
Copy link
Contributor Author

Thanks! This looks great, you'll need to sign the CLA before I can merge.

Hello Nick! I have signed the CLA and submitted a rescan. But it does not update the build. Can you please check it?

@groszewn
Copy link
Contributor

groszewn commented Dec 5, 2023

@tummala-manasa Could you please add the email used for the Git
commits to your GitHub account
? The cla/google workflow check should show the status for the different emails associated with your PR.

@tummala-manasa tummala-manasa force-pushed the issue-6276 branch 2 times, most recently from 13d85db to 8bb1a63 Compare December 11, 2023 22:16
@tummala-manasa
Copy link
Contributor Author

@tummala-manasa Could you please add the email used for the Git commits to your GitHub account? The cla/google workflow check should show the status for the different emails associated with your PR.

Hello Nick!
I was able to fix the CLA issue. Can you please merge this?

@groszewn groszewn merged commit 7123d05 into tensorflow:master Dec 12, 2023
13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants