Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tbdev turndown: No longer allow usage of tensorboard dev upload. #6638

Merged
merged 3 commits into from
Oct 24, 2023

Conversation

bmd3k
Copy link
Contributor

@bmd3k bmd3k commented Oct 17, 2023

In this step of the TensorBoard.dev turndown, we remove the ability to upload via the tensorboard dev upload command.

Instead, when a user invokes tensorboard dev upload, we print the following message, which is similar to the message we currently return in the server info from TensorBoard.dev backends:

****************************************************************
****************************************************************
****************************************************************

Uploading TensorBoard logs to https://tensorboard.dev/ is no longer
supported.

TensorBoard.dev is shutting down.

Please export your experiments by Dec 31, 2023.

See the FAQ at https://tensorboard.dev.

****************************************************************
****************************************************************
****************************************************************

We also remove a bunch of upload-specific code.

Testing:
I tested the changes by trying some version of the following commands:
bazel run tensorboard -- dev auth revoke
bazel run tensorboard -- dev upload
bazel run tensorboard -- dev list
bazel run tensorboard -- dev update-metadata
bazel run tensorboard -- dev delete
bazel run tensorboard -- dev export

@bmd3k bmd3k force-pushed the tbdev-turndown-remove-upload branch from bbb1be3 to 4ad4313 Compare October 17, 2023 17:51
@bmd3k bmd3k requested a review from arcra October 17, 2023 17:55
@bmd3k bmd3k changed the title No longer allow usage of tensorboard dev upload. tbdev turndown: No longer allow usage of tensorboard dev upload. Oct 18, 2023
tensorboard/uploader/uploader_subcommand.py Outdated Show resolved Hide resolved
@bmd3k bmd3k merged commit 3b4c4fe into tensorflow:master Oct 24, 2023
13 checks passed
groszewn pushed a commit that referenced this pull request Oct 31, 2023
We deleted the tensorboard.uploader.util.RateLImiter in #6638. However
it is used internally and needs to be returned. This is therefore a
partial rollback of #6638.
bmd3k added a commit to bmd3k/tensorboard that referenced this pull request Nov 2, 2023
…ensorflow#6638)

In this step of the TensorBoard.dev turndown, we remove the ability to
upload via the `tensorboard dev upload` command.

Instead, when a user invokes `tensorboard dev upload`, we print the
following message, which is similar to the message we currently return
in the server info from TensorBoard.dev backends:

```
****************************************************************
****************************************************************
****************************************************************

Uploading TensorBoard logs to https://tensorboard.dev/ is no longer
supported.

TensorBoard.dev is shutting down.

Please export your experiments by Dec 31, 2023.

See the FAQ at https://tensorboard.dev.

****************************************************************
****************************************************************
****************************************************************
```

We also remove a bunch of upload-specific code.

Testing:
I tested the changes by trying some version of the following commands:
`bazel run tensorboard -- dev auth revoke`
`bazel run tensorboard -- dev upload`
`bazel run tensorboard -- dev list`
`bazel run tensorboard -- dev update-metadata`
`bazel run tensorboard -- dev delete`
`bazel run tensorboard -- dev export`
@bmd3k bmd3k mentioned this pull request Nov 2, 2023
bmd3k added a commit that referenced this pull request Nov 2, 2023
…6638)

In this step of the TensorBoard.dev turndown, we remove the ability to
upload via the `tensorboard dev upload` command.

Instead, when a user invokes `tensorboard dev upload`, we print the
following message, which is similar to the message we currently return
in the server info from TensorBoard.dev backends:

```
****************************************************************
****************************************************************
****************************************************************

Uploading TensorBoard logs to https://tensorboard.dev/ is no longer
supported.

TensorBoard.dev is shutting down.

Please export your experiments by Dec 31, 2023.

See the FAQ at https://tensorboard.dev.

****************************************************************
****************************************************************
****************************************************************
```

We also remove a bunch of upload-specific code.

Testing:
I tested the changes by trying some version of the following commands:
`bazel run tensorboard -- dev auth revoke`
`bazel run tensorboard -- dev upload`
`bazel run tensorboard -- dev list`
`bazel run tensorboard -- dev update-metadata`
`bazel run tensorboard -- dev delete`
`bazel run tensorboard -- dev export`
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants