Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add delete column button on data table #6410

Merged
merged 13 commits into from
Jun 12, 2023

Conversation

bhuang1323
Copy link
Contributor

@bhuang1323 bhuang1323 commented May 31, 2023

Motivation for features / changes

Add ability to remove column directly from data table rather than navigating to settings panel to remove.

Technical description of changes

Added a new button on data table that uses existing column toggling functionality (from the settings panel) to disable selection column.

Screenshots of UI changes (or N/A)

Screenshot 2023-06-07 2 21 27 PM
video

Detailed steps to verify changes work correctly (as executed by you)

  1. Enable enableHparamsInTimeSeries feature flag.
  2. Navigate to Time Series > Scalars.
  3. Expand and add a step on a scalar card.
  4. Hover over a column on the data table, click the 'X' that appears. Confirm that the column is removed for all single selection scalar cards.
  5. Repeat with range selection by adding another step on a scalar card.

Alternate designs / implementations considered (or N/A)

@bhuang1323 bhuang1323 marked this pull request as ready for review June 5, 2023 16:12
Copy link
Contributor

@japie1235813 japie1235813 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your patience and making all those changes! Lgtm.

@japie1235813 japie1235813 merged commit 6c0f32b into tensorflow:master Jun 12, 2023
14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants