Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Embedding Projector: Fix PCA sampling message #6373

Merged
merged 1 commit into from
May 15, 2023

Conversation

alicialics
Copy link
Contributor

@alicialics alicialics commented May 9, 2023

Motivation for features / changes

Fix PCA sampling message visibility bug

Technical description of changes

dim[0] is number of points, dim[1] is number of dimensions

Screenshots of UI changes (or N/A)

image

Detailed steps to verify changes work correctly (as executed by you)

message should be hidden if using MNIST dataset

Alternate designs / implementations considered (or N/A)

@yatbear yatbear self-requested a review May 15, 2023 16:01
Copy link
Member

@yatbear yatbear left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@yatbear yatbear merged commit af20b6c into tensorflow:master May 15, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants